-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update look of Smart Search filter gallery #1916
Update look of Smart Search filter gallery #1916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! I'm suggesting some minor changes below, and then there is a merge conflict, and the need to also add email filters now that they've been merged to main. Can you sort that out and then lets merge? 😊
src/features/smartSearch/components/SmartSearchDialog/FilterGallery/filterGalleryPattern.ts
Show resolved
Hide resolved
src/features/smartSearch/components/SmartSearchDialog/FilterGallery/groupedFilters.ts
Show resolved
Hide resolved
…nted/categories-in-filter-gallery
…nted/categories-in-filter-gallery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and ready to merge! 💯
I will merge it right away in order to discover any merge conflicts that may arise with #2008.
Description
This PR updates the look of the Smart Search filter gallery, by making it more like the column gallery used in lists.
Screenshots
Changes
Notes to reviewer