Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update look of Smart Search filter gallery #1916

Merged
merged 19 commits into from
Jun 5, 2024

Conversation

ziggabyte
Copy link
Contributor

Description

This PR updates the look of the Smart Search filter gallery, by making it more like the column gallery used in lists.

Screenshots

bild

Changes

  • Adds sidebar with index of all categories, that scroll into view when clicked.
  • Updates the look of the cards, and gives each a CSS "image" that is actually a complex gradient.
  • Changes the names of the categories, and gives them descriptions
  • Adds one new category, Cross referencing, and splits the previous "campaign participation" category into Events and Tasks.

Notes to reviewer

  • We have not updated the "header" part, so it does not fit in visually at all and we are aware of that heh

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! I'm suggesting some minor changes below, and then there is a merge conflict, and the need to also add email filters now that they've been merged to main. Can you sort that out and then lets merge? 😊

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and ready to merge! 💯

I will merge it right away in order to discover any merge conflicts that may arise with #2008.

@richardolsson richardolsson merged commit e7e7bae into main Jun 5, 2024
5 checks passed
@richardolsson richardolsson deleted the undocumented/categories-in-filter-gallery branch June 5, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants