WIP: Support Babel 7 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zertosh This is needed to unblock Babel 7 for Jest: jestjs/jest#6949 |
|
@milesj, the tests are failing |
|
@jamesreggio Ping |
|
Sorry, @zertosh and @milesj, but all of the tests need to be migrated to Babel 7. I spent an hour on it so far and cannot even get a single test to run on Babel 7. I don't have any more time to spend, especially since I'm not using this package myself. (We're just using the I'm going to close this, but you may consider using my adjustments to the plugin code in any future attempt you make to support Babel 7. |
reid
pushed a commit
to reid/babel-plugin-transform-inline-imports-commonjs
that referenced
this pull request
Feb 20, 2019
This change builds on zertosh#11 by upgrading the Babel dev dependencies to Babel 7. Various packages were renamed and changed for Babel 7 and the generated code is different. - Switch to new `@babel` packages. - `es2015` and `es3` were removed from plugin names. - Continue to use select legacy es3 plugins which continue to work with Babel 7. - `@babel/preset-react` no longer strips Flow types. Include `@babel/plugin-transform-flow-strip-types` to strip Flow. - Include the Babel bridge package. - `babel-plugin-check-es2015-constants` was removed in favor of `@babel/plugin-transform-block-scoping` which violated the ES spec. See: babel/babel#6987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/templatehas a new API in Babel 7 that requires positional replacements (i.e., those with numbered placeholders like$0and$1) to be passed in via a single array argument.This PR makes the needed change, which was all that was needed to get this plugin to run in a Babel 7 environment.
The PR is not clean to merge because it regresses Babel 6 functionality. I would suggest updating the package dependencies to Babel 7 if you'd like to eventually merge this — though the
lazyoption in the Babel 7 commonjs plugin may obviate the need for this package, per the discussion here.