Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log currentSize should not be 0 when file exists and size is not 0 #2639

Merged
merged 1 commit into from Nov 25, 2022
Merged

fix: log currentSize should not be 0 when file exists and size is not 0 #2639

merged 1 commit into from Nov 25, 2022

Conversation

edieruby
Copy link
Contributor

When application restart, the currentSize reset to 0.
If it uses fileSizeRotation, the size will larger than max size, but not rotate.

@kevwan kevwan self-requested a review November 25, 2022 14:55
kevwan
kevwan approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevwan kevwan merged commit b1c3c21 into zeromicro:master Nov 25, 2022
@kevwan kevwan mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edieruby @kevwan