Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : responses whit context #2637

Merged
merged 1 commit into from Dec 3, 2022

Conversation

heyehang
Copy link
Contributor

@heyehang heyehang commented Nov 24, 2022

Context can be injected into the api global error response result event to achieve full link logging.

For example:
Method httpx.SetErrorHandler combination https://github.com/pkg/errors ,errors.Warp,errors.WithMessage is very popular. Development engineers do not need to manually output logs for error processing.

Because of the unified err interception and link log context output.

@kevwan
Copy link
Contributor

kevwan commented Nov 25, 2022

Sorry, it's a breaking change.

@kevwan kevwan added the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Nov 25, 2022
@heyehang heyehang force-pushed the feature/httpx-resp-for-ctx branch 2 times, most recently from 5e9cf7b to 968389e Compare November 25, 2022 17:52
@kevwan kevwan self-requested a review December 2, 2022 15:26
@kevwan kevwan added enhancement New feature or request and removed do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. labels Dec 3, 2022
@kevwan kevwan added this to the v1.4.3 milestone Dec 3, 2022
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevwan kevwan merged commit a644ec7 into zeromicro:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants