Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default port is used when there is no port number for k8s #2598

Merged
merged 2 commits into from Nov 27, 2022
Merged

The default port is used when there is no port number for k8s #2598

merged 2 commits into from Nov 27, 2022

Conversation

bigrocs
Copy link
Contributor

@bigrocs bigrocs commented Nov 12, 2022

Target: k8s://namespace/service-rpc-svc:8001
To
Target: k8s://namespace/service-rpc-svc

@kevwan kevwan self-requested a review November 12, 2022 14:16
@kevwan kevwan added the feature Marks an issue or PR as related to a new feature. label Nov 12, 2022
@kevwan kevwan self-assigned this Nov 15, 2022
@kevwan kevwan added this to the v1.4.3 milestone Nov 15, 2022
kevwan
kevwan approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan
Copy link
Contributor

kevwan commented Nov 27, 2022

Fix #2636

@kevwan kevwan linked an issue Nov 27, 2022 that may be closed by this pull request
为什么k8s Target一定要port呢？ #2636
Closed
@kevwan kevwan merged commit 90828a0 into zeromicro:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees

@kevwan kevwan

Labels
feature Marks an issue or PR as related to a new feature.
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

为什么k8s Target一定要port呢？
2 participants
@bigrocs @kevwan