Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conf inherit #2568

Merged
merged 11 commits into from Nov 8, 2022
Merged

feat: conf inherit #2568

merged 11 commits into from Nov 8, 2022

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Nov 3, 2022

No description provided.

@kevwan kevwan marked this pull request as draft November 4, 2022 05:08
@kevwan kevwan marked this pull request as ready for review November 4, 2022 15:25
chenquan
chenquan reviewed Nov 5, 2022
View reviewed changes
core/mapping/unmarshaler.go Outdated Show resolved Hide resolved
core/mapping/unmarshaler.go Outdated Show resolved Hide resolved
chenquan
chenquan approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@chenquan chenquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MarkJoyMa
MarkJoyMa approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@MarkJoyMa MarkJoyMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan added the feature Marks an issue or PR as related to a new feature. label Nov 7, 2022
chenquan
chenquan approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@chenquan chenquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit 1677a4d into zeromicro:master Nov 8, 2022
@kevwan kevwan deleted the feat/conf-inherit branch November 8, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenquan chenquan chenquan approved these changes

@MarkJoyMa MarkJoyMa MarkJoyMa approved these changes

@kesonan kesonan Awaiting requested review from kesonan

@re-dylan re-dylan Awaiting requested review from re-dylan

@zhoushuguang zhoushuguang Awaiting requested review from zhoushuguang

Assignees
No one assigned
Labels
feature Marks an issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevwan @zhoushuguang @chenquan @MarkJoyMa