Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix log out-of-order output and cross-file output #2424

Merged
merged 1 commit into from Sep 20, 2022
Merged

fix: fix log out-of-order output and cross-file output #2424

merged 1 commit into from Sep 20, 2022

Conversation

chenquan
Copy link
Member

@chenquan chenquan commented Sep 20, 2022 •
edited

fix log out-of-order output and cross-file output

@chenquan chenquan force-pushed the fix/log-output branch 3 times, most recently from 0e6325b to 3187711 Compare September 20, 2022 13:17
@MarkJoyMa
Copy link
Collaborator

LGTM

@kevwan kevwan merged commit 68e1536 into zeromicro:master Sep 20, 2022
@chenquan chenquan deleted the fix/log-output branch September 20, 2022 15:13
@chenquan chenquan mentioned this pull request Sep 21, 2022
Open
@Kittoa
Copy link

Kittoa commented Sep 21, 2022

this is okay too
image
Essentially because the memory is destroyed
image

@chenquan
Copy link
Member Author

this is okay too image Essentially because the memory is destroyed image

Yes, the byte slice is reused here, and the data will be overwritten.

@chenquan
Copy link
Member Author

This issue exists with plain mode in versions 1.4.1 and below, so consider using json mode until the new version is released.

@Kittoa
Copy link

Kittoa commented Sep 21, 2022

Okey, thanks.

@chenquan chenquan changed the title fix: fix log output fix: fix log out-of-order output and cross-file output Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenquan @MarkJoyMa @Kittoa @kevwan