Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix goctl rpc protoc strings.EqualFold Service.Name GoPackage #2046

Merged
merged 1 commit into from Jul 9, 2022

Conversation

LeeDF
Copy link
Contributor

@LeeDF LeeDF commented Jun 24, 2022

No description provided.

@LeeDF
Copy link
Contributor Author

LeeDF commented Jun 24, 2022

syntax = "proto3";
package pushService;
option go_package="./pushService";
service PushService {}
rpc gen code is conflict

@kevwan
Copy link
Contributor

kevwan commented Jun 25, 2022

image

It's working from my side. What's the error?

@LeeDF
Copy link
Contributor Author

LeeDF commented Jun 28, 2022

pushService.proto

syntax = "proto3";
package pushService;
option go_package = "./pushService";
message In {
  int64 id = 1;
}
message Out {
  int64 id = 2;
}
service PushService {
  rpc echo(In) returns(Out);
}

goctl rpc protoc ./*.proto -I=./ --go_out=./ --go-grpc_out=./ --zrpc_out=./
in pushservice directory contains package pushservice and package pushService

@LeeDF
Copy link
Contributor Author

LeeDF commented Jun 28, 2022

pushService.proto

syntax = "proto3";
package pushService;
option go_package = "./pushService";
message In {
  int64 id = 1;
}
message Out {
  int64 id = 2;
}
service PushService {
  rpc echo(In) returns(Out);
}

goctl rpc protoc ./*.proto -I=./ --go_out=./ --go-grpc_out=./ --zrpc_out=./ in pushservice directory contains package pushservice and package pushService

goctl version 1.3.8 darwin/amd64
protoc-gen-go v1.28.0

@LeeDF LeeDF closed this Jun 28, 2022
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


pushService.proto

syntax = "proto3";
package pushService;
option go_package = "./pushService";
message In {
  int64 id = 1;
}
message Out {
  int64 id = 2;
}
service PushService {
  rpc echo(In) returns(Out);
}

goctl rpc protoc ./*.proto -I=./ --go_out=./ --go-grpc_out=./ --zrpc_out=./ in pushservice directory contains package pushservice and package pushService

goctl version 1.3.8 darwin/amd64
protoc-gen-go v1.28.0

@LeeDF LeeDF reopened this Jun 28, 2022
Copy link
Collaborator

@kesonan kesonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am going to resolve this issue next release, Great!

@kevwan kevwan merged commit 96acf1f into zeromicro:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants