Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add codecov #1861

Merged
merged 2 commits into from May 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 40 additions & 0 deletions core/stores/mon/collection_test.go
Expand Up @@ -3,7 +3,9 @@ package mon
import (
"context"
"errors"
"strings"
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/zeromicro/go-zero/core/breaker"
Expand Down Expand Up @@ -567,6 +569,44 @@ func TestCollection_UpdateMany(t *testing.T) {
})
}

func Test_DecoratedCollectionLogDuration(t *testing.T) {
mt := mtest.New(t, mtest.NewOptions().ClientType(mtest.Mock))
defer mt.Close()
c := decoratedCollection{
Collection: mt.Coll,
brk: breaker.NewBreaker(),
}

var buf strings.Builder
w := logx.NewWriter(&buf)
o := logx.Reset()
logx.SetWriter(w)

defer func() {
logx.Reset()
logx.SetWriter(o)
}()

buf.Reset()
c.logDuration("foo", time.Millisecond, nil, "bar")
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "bar")

buf.Reset()
c.logDuration("foo", time.Millisecond, errors.New("bar"), make(chan int))
assert.Contains(t, buf.String(), "bar")

buf.Reset()
c.logDuration("foo", slowThreshold.Load()+time.Millisecond, errors.New("bar"))
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "slowcall")

buf.Reset()
c.logDuration("foo", slowThreshold.Load()+time.Millisecond, nil)
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "slowcall")
}

type mockPromise struct {
accepted bool
reason string
Expand Down
27 changes: 27 additions & 0 deletions core/stores/mon/util_test.go
@@ -1,9 +1,13 @@
package mon

import (
"errors"
"strings"
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/zeromicro/go-zero/core/logx"
)

func TestFormatAddrs(t *testing.T) {
Expand Down Expand Up @@ -33,3 +37,26 @@ func TestFormatAddrs(t *testing.T) {
assert.Equal(t, test.expect, FormatAddr(test.addrs))
}
}

func Test_logDuration(t *testing.T) {
var buf strings.Builder
w := logx.NewWriter(&buf)
o := logx.Reset()
logx.SetWriter(w)

defer func() {
logx.Reset()
logx.SetWriter(o)
}()

buf.Reset()
logDuration("foo", "bar", time.Millisecond, nil)
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "bar")

buf.Reset()
logDuration("foo", "bar", time.Millisecond, errors.New("bar"))
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "bar")
assert.Contains(t, buf.String(), "fail")
}
42 changes: 42 additions & 0 deletions core/stores/mongo/collection_test.go
Expand Up @@ -2,7 +2,9 @@ package mongo

import (
"errors"
"strings"
"testing"
"time"

"github.com/globalsign/mgo"
"github.com/golang/mock/gomock"
Expand Down Expand Up @@ -266,6 +268,46 @@ func TestCollectionUpsert(t *testing.T) {
assert.Equal(t, errDummy, err)
}

func Test_logDuration(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()

col := internal.NewMockMgoCollection(ctrl)
c := decoratedCollection{
collection: col,
brk: breaker.NewBreaker(),
}

var buf strings.Builder
w := logx.NewWriter(&buf)
o := logx.Reset()
logx.SetWriter(w)

defer func() {
logx.Reset()
logx.SetWriter(o)
}()

buf.Reset()
c.logDuration("foo", time.Millisecond, nil, "bar")
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "bar")

buf.Reset()
c.logDuration("foo", time.Millisecond, errors.New("bar"), make(chan int))
assert.Contains(t, buf.String(), "bar")

buf.Reset()
c.logDuration("foo", slowThreshold.Load()+time.Millisecond, errors.New("bar"))
assert.Contains(t, buf.String(), "bar")
assert.Contains(t, buf.String(), "slowcall")

buf.Reset()
c.logDuration("foo", slowThreshold.Load()+time.Millisecond, nil)
assert.Contains(t, buf.String(), "foo")
assert.Contains(t, buf.String(), "slowcall")
}

type mockPromise struct {
accepted bool
reason string
Expand Down
6 changes: 6 additions & 0 deletions zrpc/internal/serverinterceptors/statinterceptor_test.go
Expand Up @@ -75,6 +75,12 @@ func TestLogDuration(t *testing.T) {
}),
req: "foo",
},
{
name: "timeout",
ctx: context.Background(),
req: "foo",
duration: slowThreshold.Load() + time.Second,
},
}

for _, test := range tests {
Expand Down