Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace cli to cobra #1855

Merged
merged 10 commits into from May 7, 2022
Merged

Conversation

kesonan
Copy link
Collaborator

@kesonan kesonan commented May 2, 2022

No description provided.

@kesonan kesonan marked this pull request as draft May 2, 2022 11:40
tools/goctl/cmd/root.go Outdated Show resolved Hide resolved
@kesonan kesonan marked this pull request as ready for review May 6, 2022 06:12
Copy link
Collaborator

@zhoushuguang zhoushuguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

return copyArgs
}

func init() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to put init() at the beginning.

Copy link
Member

@chenquan chenquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fynxiu fynxiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit 5383e29 into zeromicro:master May 7, 2022
@kesonan kesonan deleted the feature/replace-cli branch June 5, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants