chore: refactor

zeromicro · Oct 22, 2022 · a8e142f · a8e142f
1 parent 8d3d234
commit a8e142f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/rest/handler/tracinghandler.go b/rest/handler/tracinghandler.go
@@ -12,11 +12,11 @@ import (
 	oteltrace "go.opentelemetry.io/otel/trace"
 )
 
-var dontTracingSpanNames sync.Map
+var notTracingSpans sync.Map
 
-// DontTracingSpanName disable tracing for the specified spanName.
-func DontTracingSpanName(spanName string) {
-	dontTracingSpanNames.Store(spanName, lang.Placeholder)
+// DontTraceSpan disable tracing for the specified span name.
+func DontTraceSpan(spanName string) {
+	notTracingSpans.Store(spanName, lang.Placeholder)
 }
 
 // TracingHandler return a middleware that process the opentelemetry.
@@ -36,8 +36,7 @@ func TracingHandler(serviceName, path string) func(http.Handler) http.Handler {
 				spanName = r.URL.Path
 			}
 
-			_, ok := dontTracingSpanNames.Load(spanName)
-			if ok {
+			if _, ok := notTracingSpans.Load(spanName); ok {
 				return
 			}
 

diff --git a/rest/handler/tracinghandler_test.go b/rest/handler/tracinghandler_test.go
@@ -60,7 +60,7 @@ func TestDontTracingSpanName(t *testing.T) {
 		Sampler:  1.0,
 	})
 
-	DontTracingSpanName("bar")
+	DontTraceSpan("bar")
 
 	for _, test := range []string{"", "bar", "foo"} {
 		t.Run(test, func(t *testing.T) {