Fix embeddable support when used with file (ie xml) mapping #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotaion/attribute drivers do not register embeddables in class metadata but the file drivers do.
|
I opted not to include tests as it would require yet another test matrix element (duplicating all the mapping), further complicating the test suite. |
|
@mergeMarc, can you confirm this fixes #270 in your real app? Then I'll merge/release. |
|
Tested the patch with my application and everything works now even when removing Thank you so much for looking into this. |
|
Perfect! Tagged a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotaion/attribute drivers do not register embeddables in class metadata but the file drivers do.
Reference: doctrine/orm#8138
Fixes: #270