This repository was archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Add SameSite directive #174 #186
Merged
michalbundyra
merged 6 commits into
zendframework:develop
from
MadCat34:fix/174-SameSite
Dec 3, 2019
Merged
Add SameSite directive #174 #186
michalbundyra
merged 6 commits into
zendframework:develop
from
MadCat34:fix/174-SameSite
Dec 3, 2019
+124
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbundyra
suggested changes
Sep 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MadCat34 Thanks for your contribution :)
There should be 3rd option: "None". See: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-03
Thanks!
Hi @webimpress I have added a constant for None value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MadCat34 Looks good, just small comments.
MadCat34
commented
Sep 25, 2019
…is passed to SameSite directive #174
michalbundyra
added a commit
that referenced
this pull request
Dec 3, 2019
Add SameSite directive #174
michalbundyra
added a commit
that referenced
this pull request
Dec 3, 2019
Thanks, @MadCat34! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to add the SameSite directive in SetCookie header
See #174