Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Add SameSite directive #174 #186

Merged
merged 6 commits into from
Dec 3, 2019
Merged

Add SameSite directive #174 #186

merged 6 commits into from
Dec 3, 2019

Conversation

MadCat34
Copy link
Contributor

This PR allow to add the SameSite directive in SetCookie header

See #174

@michalbundyra michalbundyra self-assigned this Sep 25, 2019
@michalbundyra michalbundyra added this to the 2.11.0 milestone Sep 25, 2019
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadCat34 Thanks for your contribution :)

There should be 3rd option: "None". See: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-03

Thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MadCat34
Copy link
Contributor Author

Hi @webimpress
Thanks for your return.

I have added a constant for None value.

Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadCat34 Looks good, just small comments.

michalbundyra added a commit that referenced this pull request Dec 3, 2019
michalbundyra added a commit that referenced this pull request Dec 3, 2019
@michalbundyra michalbundyra merged commit cc1d12f into zendframework:develop Dec 3, 2019
michalbundyra added a commit that referenced this pull request Dec 3, 2019
@michalbundyra
Copy link
Member

Thanks, @MadCat34!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants