Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Fix for timeout config parameter validation #168

Merged
merged 3 commits into from Jan 22, 2019
Merged

Fix for timeout config parameter validation #168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a2995c
Fix for timeout config parameter validation
klimser Jan 11, 2019
1c9f249
Code style fix
klimser Jan 11, 2019
a734185
Cleaning
klimser Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client/Adapter/Curl.php
View file
Open in desktop
Expand Up @@ -209,7 +209,7 @@ public function connect($host, $port = 80, $secure = false)
$connectTimeout = null;
}

if ($connectTimeout !== null && (! is_int($connectTimeout) || ! is_numeric($connectTimeout))) {
if ($connectTimeout !== null && !is_int($connectTimeout) && !is_numeric($connectTimeout)) {
throw new AdapterException\InvalidArgumentException(sprintf(
'integer or numeric string expected, got %s',
gettype($connectTimeout)
Expand Down
2 changes: 1 addition & 1 deletion src/Client/Adapter/Socket.php
View file
Open in desktop
Expand Up @@ -263,7 +263,7 @@ public function connect($host, $port = 80, $secure = false)
$connectTimeout = $this->config['timeout'];
}

if ($connectTimeout !== null && (! is_int($connectTimeout) || ! is_numeric($connectTimeout))) {
if ($connectTimeout !== null && !is_int($connectTimeout) && !is_numeric($connectTimeout)) {
throw new AdapterException\InvalidArgumentException(sprintf(
'integer or numeric string expected, got %s',
gettype($connectTimeout)
Expand Down