Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Zend\Http\Client should not accept relative URIs #170

Open
thomasvargiu opened this issue Jan 17, 2019 · 3 comments
Open

Zend\Http\Client should not accept relative URIs #170

thomasvargiu opened this issue Jan 17, 2019 · 3 comments

Comments

@thomasvargiu
Copy link
Contributor

I saw a new PR (#149) to resolve an issue (#36) with relative URIs. But as a @samsonasik said in a comment, relative URI's should not be used.

No adapters can actually work when no host is found in the URI, and logically I think it would be useless.

I think #149 should be reverted, adding a check in setUri() method to check if it contains the host parameter.

@samsonasik
Copy link
Contributor

relative URI seems ok, but I think next todo is prepend the existing host when request sent

@michalbundyra
Copy link
Member

@samsonasik

relative URI seems ok, but I think next todo is prepend the existing host when request sent

how do you mean? From where we can get the host if it was not set with the uri?

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-http; a new issue has been opened at laminas/laminas-http#3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants