Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend\Http\Client should not accept relative URIs #3

Closed
weierophinney opened this issue Dec 31, 2019 · 3 comments
Closed

Zend\Http\Client should not accept relative URIs #3

weierophinney opened this issue Dec 31, 2019 · 3 comments
Labels
Bug Something isn't working Enhancement Help Wanted

Comments

@weierophinney
Copy link
Member

I saw a new PR (#149) to resolve an issue (#36) with relative URIs. But as a @samsonasik said in a comment, relative URI's should not be used.

No adapters can actually work when no host is found in the URI, and logically I think it would be useless.

I think #149 should be reverted, adding a check in setUri() method to check if it contains the host parameter.


Originally posted by @thomasvargiu at zendframework/zend-http#170

@weierophinney
Copy link
Member Author

relative URI seems ok, but I think next todo is prepend the existing host when request sent


Originally posted by @samsonasik at zendframework/zend-http#170 (comment)

@weierophinney
Copy link
Member Author

@samsonasik

relative URI seems ok, but I think next todo is prepend the existing host when request sent

how do you mean? From where we can get the host if it was not set with the uri?


Originally posted by @michalbundyra at zendframework/zend-http#170 (comment)

@weierophinney
Copy link
Member Author

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

You can continue using laminas/laminas-http safely.
Its successor will be PSR-7 in a later revision of laminas/laminas-mvc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement Help Wanted
Projects
None yet
Development

No branches or pull requests

1 participant