Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Allow usage of Reader without GooglePlayPodcast extension #81

Commits on Jun 18, 2018

  1. Allow usage of Reader without GooglePlayPodcast extension

    Custom implementations of `ExtensionManagerInterface` may not have _new
    core_ extensions present. As a result, when upgrading, an exception is
    thrown due to inability to load the new extension.
    
    This was discovered with the 2.10 release, when we added a new core
    extension, GooglePlayPodcast; see zendframework#80 and https://www.drupal.org/project/drupal/issues/2976335
    for more details.
    
    As such, we now check for _new_ core extensions before registering them.
    When we discover they are not in the extension manager, we emit an
    `E_USER_NOTICE` indicating the user should update their
    `ExtensionManagerInterface` implementation to add entries for the new
    extension, but then continue on without registering the extension. This
    ensures no exception is thrown.
    weierophinney committed Jun 18, 2018
    Copy the full SHA
    dfbb10f View commit details
    Browse the repository at this point in the history
  2. Follow same pattern in Writer subcomponent regarding GooglePlayPodcas…

    …t extension
    
    This patch adapts the same pattern used in the `Reader` subcomponent
    with regards to conditionally loading newly introduced extensions to the
    `Writer` subcomponent: if the extension manager does not know of the
    extension, it is not registered, and an `E_USER_NOTICE` is emitted
    prompting the developer to add entries to their extension manager
    implementation.
    weierophinney committed Jun 18, 2018
    Copy the full SHA
    af6dc41 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    bfd6b1a View commit details
    Browse the repository at this point in the history