Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Bug19 mirgration static to dynamic #23

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

necromant2005
Copy link

original bug: #19

@Xerkus Xerkus added this to the 3.0.0 milestone Mar 29, 2017
@@ -209,13 +227,13 @@ public function __call($method, $args)
*/
protected function _loadExtensions()
{
$all = Reader::getExtensions();
$all = $this->Reader()->getExtensions();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like get is missing here.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-feed; a new issue has been opened at laminas/laminas-feed#11.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-feed. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-feed to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-feed.
  • In your clone of laminas/laminas-feed, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants