Commits on Jul 11, 2019

1. Modify detection of HTTPS …

   This modifies the detection of HTTPS by checking whether the lower-case value of the HTTPS-key of the server variable equals 'on'. Before that checked whether the value did *not* match 'off' which meant that the nginx-default for non-HTTPS connections (which, according to the [documentation](http://nginx.org/en/docs/http/ngx_http_core_module.html#var_https) is an empty string) did in fact match and returned that the connection *is* encrypted.
   
   This fixes #362
   # Conflicts:
   #	src/functions/marshal_uri_from_sapi.php

   

   michalbundyra committed Jul 11, 2019
   Copy the full SHA

   ae3aec8 View commit details

   Browse the repository at this point in the history

2. Add test to verify Scheme retrieval is correct …

   This adds the test and the CHANGELOG-entry for the changed method
   
   # Conflicts:
   #	CHANGELOG.md

   

   michalbundyra committed Jul 11, 2019
   Copy the full SHA

   e383d13 View commit details

   Browse the repository at this point in the history

3. Apply changes to comply with CodeReview …

   This modifies the copyright-date, adds some spaces before and after the
   arrow, replaces double quotes with single quotes and modifies a function
   docBlock.

   

   heiglandreas authored and michalbundyra committed Jul 11, 2019
   Copy the full SHA

   dd593d0 View commit details

   Browse the repository at this point in the history

4. Fix more CS issues

   

   heiglandreas authored and michalbundyra committed Jul 11, 2019
   Copy the full SHA

   b8ca384 View commit details

   Browse the repository at this point in the history

5. Remove typehints and RTH to work on PHP 5.6

   

   michalbundyra committed Jul 11, 2019
   Copy the full SHA

   3fb8cc2 View commit details

   Browse the repository at this point in the history

6. Fixed invalid header value in test …

   It is not possible that header value will be true for HTTPS.
   It is `on`/`On`/`ON` when it's enabled, and `off` (apache) or empty string
   (nginx) otherwise.

   

   michalbundyra committed Jul 11, 2019
   Copy the full SHA

   a3446e5 View commit details

   Browse the repository at this point in the history

7. CS fix: shorten http user agent name as it doesn't matter for the test

   

   michalbundyra committed Jul 11, 2019
   Copy the full SHA

   07cd173 View commit details

   Browse the repository at this point in the history