Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

fix (Stream) Fix the fatal error on parameter 2 #352

Closed
wants to merge 1 commit into from

Conversation

farpat
Copy link

@farpat farpat commented Jan 3, 2019

Provide a narrative description of what you are trying to accomplish:

  • [ x ] Are you fixing a bug?

When $length variable of Stream@read method is strictly a string (even if this one contains a number).

@Ocramius
Copy link
Member

Ocramius commented Jan 3, 2019

The API strictly declares the parameter to be an int, so do pass an integer to it.

Closing as invalid.

Please also consider installing a static analysis tool such as phpstan or psalm in your project, to prevent these issues upfront.

@Ocramius Ocramius closed this Jan 3, 2019
@farpat
Copy link
Author

farpat commented Jan 3, 2019

Thanks for response. As you talk, I must a PR on an other repository.

Thanks :)

@farpat farpat deleted the patch-1 branch January 3, 2019 10:02
@Ocramius Ocramius self-assigned this Jan 3, 2019
@farpat
Copy link
Author

farpat commented Jan 3, 2019

For information, this fix is passed here : slimphp/Slim#2558

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants