Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Add integration tests #325

Merged
merged 9 commits into from Sep 5, 2018
Merged

Commits on Aug 12, 2018

  1. Add integration tests

    Nyholm committed Aug 12, 2018
    Copy the full SHA
    9ca94c5 View commit details
    Browse the repository at this point in the history
  2. cs

    Nyholm committed Aug 12, 2018
    Copy the full SHA
    a47aba7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Incorporate feedback

    - Changes `$DEPENDENCIES` to `$INTEGRATION_DEPS` in `.travis.yml`, and
      changes conditional in `install` script to check for a non-empty value.
    - Updates license docblock in new files.
    weierophinney committed Sep 5, 2018
    Copy the full SHA
    6328ae3 View commit details
    Browse the repository at this point in the history
  2. Ensure that an empty array cannot be provided as a set of headers

    PSR-7 requires a string or array of strings; if an array is provided, it
    cannot be empty.
    weierophinney committed Sep 5, 2018
    Copy the full SHA
    ee4bcdc View commit details
    Browse the repository at this point in the history
  3. Ensure we only store the _values_ of arrays provided as headers

    Doing so ensures that when we merge values via `withAddedHeader()`, we
    retain the original values when key collissions might normally occur.
    
    Fixes compatibility with PSR-7.
    weierophinney committed Sep 5, 2018
    Copy the full SHA
    4a957e0 View commit details
    Browse the repository at this point in the history
  4. Adds validation to withParsedBody()

    Per the PSR-7 spec, should only allow arrays, objects, or null values.
    weierophinney committed Sep 5, 2018
    Copy the full SHA
    3db54a5 View commit details
    Browse the repository at this point in the history
  5. Set password segment of user info if not null

    Previously, a lazy `if ($password)` check meant that a value of `0`
    would be ignored; it now checks more specifically for `if (null !==
    $password)`.
    weierophinney committed Sep 5, 2018
    Copy the full SHA
    62124e0 View commit details
    Browse the repository at this point in the history
  6. Removes two invalid tests

    `MessageTraitTest` had two tests that were for behavior not supported by
    PSR-7:
    
    - `testHeaderExistsIfWithNoValues`
    - `testHeaderWithNoValues`
    
    As the integration tests demonstrate, these were not valid scenarios. As
    such, the tests are removed.
    weierophinney committed Sep 5, 2018
    Copy the full SHA
    e367b20 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    5758b2e View commit details
    Browse the repository at this point in the history