chore(tags): migrate Tag examples to storybook #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
requested changes
Jan 19, 2021
| > | ||
| {includeAvatar && ( | ||
| <Tag.Avatar> | ||
| <img alt="" src={`images/avatar-${Math.floor(Math.random() * 70 + 1)}.png`} /> |
There was a problem hiding this comment.
Let's simplify the code (and deployment size) by selecting a single, fixed avatar.
There was a problem hiding this comment.
Updated to a single image.
jzempel
requested changes
Jan 19, 2021
| docs: { | ||
| storyDescription: ` | ||
| The following examples demonstrates using the \`isRegular\` prop combined with | ||
| mixed weight content. Check out the code for details. |
There was a problem hiding this comment.
The text indicates that I can check out the code, but the "Show code" button is disabled.
There was a problem hiding this comment.
Was able to track it down to this bug storybookjs/storybook#13362
I've updated this story as well as 2 "No code available" failures in the Avatar examples.
jzempel
approved these changes
Jan 19, 2021
|
Updated to "Truncation". Much better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
react-tagsdocumentation to Storybook.Checklist
👌 design updates are Garden Designer approved (add thedesigner as a reviewer)
yarn start)?bedrock)💂♂️ includes new unit tests