Bump faraday to 0.17.5 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
token-cjg
force-pushed
the
cgoddard/bump_faraday
branch
from
442298b
to
ddde305
Compare
token-cjg
force-pushed
the
cgoddard/bump_faraday
branch
from
ddde305
to
3334651
Compare
etanxing
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
Per #355, the faraday version used by ZAT is quite old, and it appears that the version associated to ZAT is not compatible with ruby 2.5+. Since
.ruby-versionis set to 2.6.9, let's therefore bump to something slightly more recent.Compare diff: lostisland/faraday@v0.9.2...v0.17.5 .
Tasks
References
Risks
zat serverandzat theme preview.