Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DINGO-1663] Remove all references to targets from ZAS #323

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zendesk-NathanBellette
Copy link

@Zendesk-NathanBellette Zendesk-NathanBellette commented Feb 17, 2022

🐕

/cc @zendesk/dingo

Description

Remove all references to targets from ZAS. This work is related to this PR

References

https://zendesk.atlassian.net/browse/DINGO-1663

Before merging this PR

  • Fill out the Risks section
  • Think about performance and security issues

Risks

  • [RUNTIME] Can this change affect apps rendering for a user?
  • [HIGH | medium | low] What features does this touch?

…in error

Add unit test to ensure having a requirement type of targets results in an invalid_requirement_type error
@Zendesk-NathanBellette Zendesk-NathanBellette marked this pull request as ready for review February 17, 2022 05:14
@Zendesk-NathanBellette Zendesk-NathanBellette requested a review from a team as a code owner February 17, 2022 05:14
@Zendesk-NathanBellette Zendesk-NathanBellette marked this pull request as draft February 17, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant