check for both nil and empty string as missing host

Newer URI versions set host to an empty string (instead of nil) for URL like “https://”
zendesk · May 11, 2023 · b647c71 · b647c71
1 parent 22b9bc5
commit b647c71
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/zendesk_apps_support/validations/manifest.rb b/lib/zendesk_apps_support/validations/manifest.rb
@@ -434,7 +434,8 @@ def no_template_format_error(manifest)
 
         def valid_url?(value)
           uri = URI.parse(value)
-          uri.is_a?(URI::HTTP) && !uri.host.nil?
+          host_empty = uri.host.nil? || uri.host == ''
+          uri.is_a?(URI::HTTP) && !host_empty
         rescue URI::InvalidURIError
           false
         end