Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump v3.0.5 #561

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Bump v3.0.5 #561

merged 2 commits into from
Sep 6, 2023

Conversation

fbvilela
Copy link
Contributor

@fbvilela fbvilela commented Sep 6, 2023 •
edited

Description

Version bump. a few more endpoints having support to CBP

v3.0.4...v3.0.5

new endpoints

  • organizations/:id/users
  • organizations/:id/tickets
  • tickets/:id/audits
  • brands
  • users

@fbvilela fbvilela requested a review from a team as a code owner September 6, 2023 04:37
ecoologic
ecoologic reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ecoologic ecoologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog is missing and it would be nice to have the list of endpoints in the PR description

@ecoologic
Copy link
Contributor

Are you double checking that these /\d+/ are correct? I guess for rails stuff there is no problem, but I would be more confident with %r{/([^/]+)/}

ecoologic
ecoologic approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ecoologic ecoologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@fbvilela fbvilela merged commit ff6b2b5 into master Sep 6, 2023
7 checks passed
@fbvilela fbvilela deleted the bump-v3.0.5 branch September 6, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecoologic ecoologic ecoologic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbvilela @ecoologic