Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RED-1894] Add cbp support to more endpoints #560

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

fbvilela
Copy link
Contributor

@fbvilela fbvilela commented Sep 5, 2023

Description

Adding more CBP support

References

  • RED-1894

@fbvilela fbvilela requested a review from a team as a code owner September 5, 2023 06:22
Copy link
Contributor

@ecoologic ecoologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -407,7 +411,7 @@ class Ticket < Resource
extend DestroyMany

def self.cbp_path_regexes
[/^tickets$/]
[/^tickets$/, %r{organizations/\d+/tickets}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no alphanumeric in ids (we need to keep this in mind for all endpoints)

end
end

describe '/organiozations/:id/tickets' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

@fbvilela fbvilela merged commit 41ad85e into master Sep 6, 2023
7 checks passed
@fbvilela fbvilela deleted the fvilela/more_cbp_work branch September 6, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants