Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using Faraday 1.x release in gemspec #421

Merged
merged 3 commits into from Feb 26, 2020
Merged

Allow using Faraday 1.x release in gemspec #421

merged 3 commits into from Feb 26, 2020

Conversation

wpeterson
Copy link
Contributor

@wpeterson wpeterson commented Feb 13, 2020 •
edited

Faraday has released a 1.0 version last month, but zendesk_api depends on the 0.x series of Faraday versions by gemspec.

Let's allow using the latest version of Faraday but avoid a major upgrade to 2.x by maintaining a version constraint.

Backward compatibility fixes (v. 0.9 - v 1.x compatible):

@wpeterson
Allow using Faraday 1.x release in gemspec
45e2b08 
Require < 2.x, but greater than 0.9
@wpeterson
Update references to deprecated Faraday errors
8dd6e5f
@wpeterson
Fix EtagCache ENV serialization/caching
dd600d6 
The EtagCache middleware caches the response `env` structure to allow restoring a cached response, but the `body` attribute is no longer real data, it dynamically dispatches to either `request_body` or `response_body`.  This causes an `env` being cached with a `response_body` value but no `body` value on cache hit/read, triggering a nil body to downstream middleware.
@wpeterson
Copy link
Contributor Author

@nogates Apologies for the noise on this. Found/fixed two backward compatibility issues, but this should be good to go and ready for review.

You seemed like the most active maintainer, but please let me know if I should ask someone else to review.

@wpeterson
Copy link
Contributor Author

I tested these changes with faraday gem versions 0.9.0 and 1.0.0

@wpeterson
Copy link
Contributor Author

Friendly ping on this, I'd love to get a review.

@wpeterson wpeterson requested review from ggrossman and removed request for nogates February 25, 2020 14:42
@nogates nogates merged commit 29a244c into zendesk:master Feb 26, 2020
@nogates
Copy link
Collaborator

nogates commented Feb 26, 2020 •
edited

Thanks for the PR @wpeterson and sorry for the delay in merging this!
I will cut a new release soon

@davidtaylorhq
Copy link
Contributor

Thanks for working on this @wpeterson!

@nogates would it be possible to get a new release cut soon? This is the last blocker on us updating our faraday version at Discourse. Let us know if there's anything we can do to help.

@davidtaylorhq davidtaylorhq mentioned this pull request Mar 16, 2020
Merged
@nogates
Copy link
Collaborator

nogates commented Apr 21, 2020

I am so sorry it has taken me such a long time to release the latest version. I had just pushed it to rubygems.

@wpeterson
Copy link
Contributor Author

@nogates @davidtaylorhq Thanks to you both for your help getting this work in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossman ggrossman Awaiting requested review from ggrossman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wpeterson @nogates @davidtaylorhq