pass kwargs in history #4108
Merged
pass kwargs in history #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Feb 29, 2024
| @@ -38,7 +38,7 @@ def read(id, *args, include_value: false) | |||
| end | |||
|
|
|||
| def history(id, include_value: false, **options) | |||
| history = backend.history(id, options) || raise(ActiveRecord::RecordNotFound) | |||
| history = backend.history(id, **options) || raise(ActiveRecord::RecordNotFound) | |||
There was a problem hiding this comment.
can you make a test that fails when this is not added (I assume by using the vault backend in the test)
... or somehow changing the current testing backend to behave the same as the backend that failed
grosser
approved these changes
Feb 29, 2024
zendesk-mattlefevre
force-pushed
the
zendesk-mattlefevre/fix-secret-manager
branch
from
697f28d
to
0ec5578
Compare
zendesk-mattlefevre
deleted the
zendesk-mattlefevre/fix-secret-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing an error in lib/samson/secrets/manager.rb where the wrong number of values are being passed. Aiming to fix this error in this PR.
Risks