Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node.js from 6.1.0 to 18.19.1 #4107

Merged
merged 1 commit into from Feb 17, 2024
Merged

Conversation

orien
Copy link
Contributor

@orien orien commented Feb 17, 2024

This closely matches the version used in the Docker image.

FROM ruby:3.2.2-slim

> docker run -it --rm ruby:3.2.2-slim bash
root@3ad2fc0aed76:/# apt-get update -qq
root@3ad2fc0aed76:/# apt-get install nodejs -yqq >/dev/null 2>&1
root@3ad2fc0aed76:/# node --version
v18.19.0

@orien orien marked this pull request as ready for review February 17, 2024 05:20
@orien orien requested a review from grosser as a code owner February 17, 2024 05:20
Copy link
Contributor

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda weird that it had the v in front ... but should be fine according to https://docs.render.com/node-version

@grosser grosser merged commit 8d5e7a0 into zendesk:master Feb 17, 2024
9 checks passed
@orien orien deleted the nodejs-18 branch February 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants