Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump marco polo to fix warning #4103

Merged
merged 1 commit into from Feb 15, 2024
Merged

bump marco polo to fix warning #4103

merged 1 commit into from Feb 15, 2024

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Feb 13, 2024

@rsb
Copy link
Contributor

rsb commented Feb 13, 2024

What's up with all the failing tests?

@grosser
Copy link
Contributor Author

grosser commented Feb 13, 2024

maybe need to require pry first or bump it too ... will revisit

@rsb
Copy link
Contributor

rsb commented Feb 13, 2024

➜ bin/rails s
Puma starting in single mode...
* Puma version: 5.6.8 (ruby 3.0.6-p216) ("Birdie's Version")
*  Min threads: 8
*  Max threads: 250
*  Environment: development
*          PID: 33673
! Unable to load application: NoMethodError: undefined method `new' for Pry::Prompt:Module
bundler: failed to load command: puma (/Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/bin/puma)
/Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/gems/marco-polo-2.0.3/lib/marco-polo.rb:28:in `<main>': undefined method `new' for Pry::Prompt:Module (NoM
ethodError)
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:60:in `require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:60:in `block (2 levels) in require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:55:in `each'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:55:in `block in require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:44:in `each'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:44:in `require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler.rb:175:in `require'
        from /Users/robert.scottbuccleuch/Code/zendesk/samson/config/application.rb:24:in `<main>'
        from /Users/robert.scottbuccleuch/Code/zendesk/samson/config/environment.rb:3:in `require_relative'
        from /Users/robert.scottbuccleuch/Code/zendesk/samson/config/environment.rb:3:in `<main>'
        from config.ru:4:in `require_relative'
        from config.ru:4:in `block in <main>'
        ```

@grosser
Copy link
Contributor Author

grosser commented Feb 14, 2024

can't reproduce locally on 3.2 so I'll get that merged first and then revisit

@rsb
Copy link
Contributor

rsb commented Feb 14, 2024

Should I be testing locally on 3.2?

@grosser
Copy link
Contributor Author

grosser commented Feb 14, 2024

no, I just can't get 3.0 to run :D

@grosser
Copy link
Contributor Author

grosser commented Feb 14, 2024

rebased, should be fixed now 🤞

@grosser grosser merged commit 7280eea into master Feb 15, 2024
9 checks passed
@grosser grosser deleted the grosser/polo branch February 15, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants