fix: ignore 'RecreatingFailedPod' event reason for StatefulSets due to bug in 1.27 #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
approved these changes
Nov 16, 2023
a7i
force-pushed
the
amir/statefulset-RecreatingFailedPod
branch
from
9def2f6
to
3c6ad7a
Compare
|
addressed in 1.27.7 |
Timothy-Dougherty
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.
In this PR, the behavior for pods being deleted while running was changed to be one of Succeeded or Failed. This makes sense for Jobs but not for StatefulSet.
Currently, a rollout of StatefulSet leads to:
The change is being cherry-picked to 1.27 mainline but not yet released.
References
Risks