Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not send github access-tokens in query params #3716

Merged
merged 1 commit into from Feb 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -26,7 +26,7 @@ gem 'sawyer'
gem 'dalli'
gem 'omniauth'
gem 'omniauth-oauth2'
gem 'omniauth-github'
gem 'omniauth-github', git: "https://github.com/omniauth/omniauth-github.git" # needs >1.3.0
gem 'omniauth-google-oauth2'
gem 'omniauth-ldap'
gem 'omniauth-gitlab'
Expand Down
13 changes: 9 additions & 4 deletions Gemfile.lock
Expand Up @@ -7,6 +7,14 @@ GIT
minitest (~> 5.10)
railties (~> 6.0.0)

GIT
remote: https://github.com/omniauth/omniauth-github.git
revision: 967d76979b6bf9bb0b71b255ad204f8931f65be6
specs:
omniauth-github (1.3.0)
omniauth (~> 1.5)
omniauth-oauth2 (>= 1.4.0, < 2.0)

GIT
remote: https://github.com/zendesk/vault-ruby.git
revision: 96be391a2fd50a42871c8b9dc3c59fddbdbdc556
Expand Down Expand Up @@ -414,9 +422,6 @@ GEM
multi_json (~> 1.7)
omniauth (~> 1.1)
omniauth-oauth (~> 1.0)
omniauth-github (1.3.0)
omniauth (~> 1.5)
omniauth-oauth2 (>= 1.4.0, < 2.0)
omniauth-gitlab (1.0.2)
omniauth (~> 1.0)
omniauth-oauth2 (~> 1.0)
Expand Down Expand Up @@ -649,7 +654,7 @@ DEPENDENCIES
octokit
omniauth
omniauth-bitbucket
omniauth-github
omniauth-github!
omniauth-gitlab
omniauth-google-oauth2
omniauth-ldap
Expand Down