Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump omniauth-github to stop sending access-token via query params #3713

Merged
merged 1 commit into from Feb 5, 2020

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Feb 5, 2020

github is sending emails about it "Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated.
"

confirmed working locally by printing in config/initializers/faraday.rb

@zendesk/compute

@grosser grosser requested a review from a team February 5, 2020 22:48
@grosser grosser merged commit 37f5195 into master Feb 5, 2020
@grosser grosser deleted the grosser/token branch February 5, 2020 23:41
@patrobinson
Copy link
Contributor

I don't think this works, because omniauth-github has not released a new gem version for this change. The current maintainers are waiting for someone to give them access omniauth/omniauth-github#87 so we may have to use the github source.

@grosser
Copy link
Contributor Author

grosser commented Feb 6, 2020

there might be more bugs in there, but I can see it clearly not working in 925b687 and being better after the update 🤷‍♂
PR welcome if you can find another area where it uses the query

@patrobinson
Copy link
Contributor

The code to fix this was only committed yesterday omniauth/omniauth-github#84

Github only send you an email every 3 days it says so maybe it'll come through then?

@grosser
Copy link
Contributor Author

grosser commented Feb 7, 2020 via email

@grosser
Copy link
Contributor Author

grosser commented Feb 7, 2020

yeah, when I add logging deeper down it shows that it still uses params ... time for git dependency ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants