Merge pull request #4109 from zendesk/amir/karmada-sync-failed

karmada: ignore sync failure errors since they are temporary
zendesk · Mar 8, 2024 · fd351f2 · fd351f2
2 parents f184b60 + c5fae89
commit fd351f2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/plugins/kubernetes/app/models/kubernetes/resource_status.rb b/plugins/kubernetes/app/models/kubernetes/resource_status.rb
@@ -29,7 +29,8 @@ class ResourceStatus
       # karmada can fail to sync a resource when something else also updated the resource,
       # this does not necessarily indicate that sync will be broken forever
       All: [
-        'ApplyPolicyFailed'
+        'ApplyPolicyFailed',
+        'SyncFailed'
       ]
     }.freeze
 

diff --git a/plugins/kubernetes/test/models/kubernetes/resource_status_test.rb b/plugins/kubernetes/test/models/kubernetes/resource_status_test.rb
@@ -111,10 +111,15 @@ def expect_event_request(&block)
           expect_event_request { details.must_equal "Error event" }
         end
 
-        it "ignores karmada sync" do
+        it "ignores karmada sync for policy failed" do
           events[0][:reason] = "ApplyPolicyFailed"
           expect_event_request { details.must_equal "Live" }
         end
+
+        it "ignores karmada syn for sync failed" do
+          events[0][:reason] = "SyncFailed"
+          expect_event_request { details.must_equal "Live" }
+        end
       end
     end
   end