Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests on ruby 3.1, 3.2, rails 7.0, drop support for rails 5.1 #22

Merged
merged 5 commits into from Jun 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 22 additions & 8 deletions .github/workflows/ci.yml
Expand Up @@ -3,7 +3,7 @@ name: CI
on: push

jobs:
test:
tests:
runs-on: ubuntu-latest

services:
Expand All @@ -18,26 +18,40 @@ jobs:
ruby-version:
- "2.7"
- "3.0"
- "3.1"
- "3.2"
gemfile:
- rails5.1
- rails5.2
- rails6.0
- rails6.1
exclude:
- ruby-version: "3.0"
gemfile: rails5.1
- ruby-version: "3.0"
- rails7.0
include:
- ruby-version: "2.7"
gemfile: rails5.2

env:
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile

steps:
- uses: zendesk/checkout@v2
- uses: zendesk/checkout@v3

- uses: zendesk/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true

- run: bundle exec rake test

tests_successful:
name: Tests passing?
needs: tests
if: always()
runs-on: ubuntu-latest
steps:
- run: |
if ${{ needs.tests.result == 'success' }}
then
echo "All tests pass"
else
echo "Some tests failed"
false
fi
1 change: 1 addition & 0 deletions .ruby-version
@@ -0,0 +1 @@
2.7.8
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,10 @@
# Unreleased

# 4.1.0
- Add support for Ruby 3.1 and 3.2
- Add support for Rails 7.0
- Drop support for Rails 5.1

# 4.0.1

- Bug fix: Cast job audit to the configured auditor class when enqueuing
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
@@ -1 +1 @@
eval_gemfile('gemfiles/rails5.1.gemfile')
eval_gemfile('gemfiles/rails6.1.gemfile')
9 changes: 9 additions & 0 deletions gemfiles/common.rb
@@ -1,3 +1,12 @@
source 'https://rubygems.org'

gemspec path: '..'

gem "bump"
gem "rake"
gem "minitest"
gem "minitest-rg"
gem "mocha"
gem "timecop"
gem "pry"
gem "sqlite3"
3 changes: 0 additions & 3 deletions gemfiles/rails5.1.gemfile

This file was deleted.

3 changes: 3 additions & 0 deletions gemfiles/rails7.0.gemfile
@@ -0,0 +1,3 @@
eval_gemfile('common.rb')

gem 'activerecord', '~> 7.0.0'
15 changes: 3 additions & 12 deletions resque-durable.gemspec
@@ -1,25 +1,16 @@
Gem::Specification.new do |s|
s.name = "resque-durable"
s.version = "4.0.3"
s.version = "4.1.0"
s.authors = ["Eric Chapweske", "Ben Osheroff"]
s.summary = "Resque queue backed by database audits, with automatic retry"
s.homepage = "https://github.com/zendesk/resque-durable"
s.license = "MIT"
s.files = `git ls-files lib`.split($/)

s.required_ruby_version = ">= 2.6"
s.required_ruby_version = ">= 2.7"

s.add_runtime_dependency("activerecord", ">= 5.1")
s.add_runtime_dependency("activerecord", ">= 5.2")
s.add_runtime_dependency("resque", "~> 1.27")
s.add_runtime_dependency("uuidtools", "~> 2.2")
s.add_runtime_dependency("redis", "< 5")

s.add_development_dependency("bump")
s.add_development_dependency("rake")
s.add_development_dependency("minitest")
s.add_development_dependency("minitest-rg")
s.add_development_dependency("mocha")
s.add_development_dependency("timecop")
s.add_development_dependency("pry")
s.add_development_dependency("sqlite3")
end
10 changes: 5 additions & 5 deletions test/queue_audit_test.rb
Expand Up @@ -57,7 +57,7 @@ class QueueAuditTest < Minitest::Test
Timecop.freeze(Time.now) do
@audit.complete!

assert_equal Time.now, @audit.completed_at
assert_equal Time.now.floor(6), @audit.completed_at
assert_equal true, @audit.complete?
end
end
Expand Down Expand Up @@ -129,7 +129,7 @@ class QueueAuditTest < Minitest::Test
@audit.enqueued!
end

assert_equal an_hour_ago, @audit.enqueued_at
assert_equal an_hour_ago.floor(6), @audit.enqueued_at
end

end
Expand All @@ -141,7 +141,7 @@ class QueueAuditTest < Minitest::Test
@audit.enqueued!
end

assert_equal (an_hour_ago + 10.minutes), @audit.timeout_at
assert_equal (an_hour_ago + 10.minutes).floor(6), @audit.timeout_at
end

it 'allows configuration of the timeout' do
Expand Down Expand Up @@ -184,13 +184,13 @@ class QueueAuditTest < Minitest::Test
Timecop.freeze(ts) do
@audit.enqueued!
end
assert_equal ts + 10.minutes, @audit.timeout_at
assert_equal (ts + 10.minutes).floor(6), @audit.timeout_at

ts = 30.minutes.ago
Timecop.freeze(ts) do
@audit.heartbeat!
end
assert_equal ts + 10.minutes, @audit.timeout_at
assert_equal (ts + 10.minutes).floor(6), @audit.timeout_at
end
end

Expand Down
6 changes: 3 additions & 3 deletions test/schema.rb
Expand Up @@ -6,9 +6,9 @@
t.string :job_klass, :null => false
t.string :payload, :null => false
t.integer :enqueue_count, :default => 0
t.datetime :enqueued_at
t.datetime :completed_at
t.datetime :timeout_at
t.datetime :enqueued_at, precision: 6
t.datetime :completed_at, precision: 6
t.datetime :timeout_at, precision: 6
t.timestamps :null => true
end
add_index(:durable_queue_audits, :enqueued_id, :unique => true)
Expand Down