Rename long and short
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause it is reserved words in ES1-3. It is ok for ES2015, but it still breaks down Closure Compiler.
| @@ -25,8 +25,8 @@ module.exports = function(val, options){ | |||
| options = options || {}; | |||
| if ('string' == typeof val) return parse(val); | |||
| return options.long | |||
There was a problem hiding this comment.
This should use options['long'], since the reserved word problem can still affect object properties. Also, my syntax checker complained about these not being on the same line, so maybe
return options['long'] ? fmtLong(val) : fmtShort(val);
would be better.
|
Yeah, you are right. Fixed it. 😎 |
|
@gobwas Good catch! +1 |
|
@shuvalov-anton 😎 |
|
Thanks! ❤️ |
|
Could you publish a tag as quick as possible with this PR ? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause it is reserved words in ES1-3. It is ok for ES2015, but it still breaks down Closure Compiler.