Avoid reserved words 'long' and 'short'. #886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In javascript, 'long' and 'short' are reserved words. They don't get much use, but some syntax checkers consider them errors, so it's easier just to rename the functions. Addresses socketio#807
|
Test failures appear unrelated. I'm getting ENOSPC for a few tests, which says to me that the build machine's disk is nearly full. The other errors are like , which I've seen on a few other open pulls here. I don't think this is related to my change. |
|
Doesn't make sense to submit a pull request here as that code is in a dependency not in socket.io itself. This is actually a dupe of vercel/ms#53 |
|
@Nibbler999 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In javascript, 'long' and 'short' are reserved words.
They were used for formatting times in a couple places.
Some syntax checkers consider their use as errors, so it's easiest just to rename the functions.
Functionally, there should be no change.
Closes #807