Add pre-commit config #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if not on_rtd: | ||
| # only import and set the theme if we're building docs locally | ||
| import sphinx_rtd_theme | ||
| html_theme = 'sphinx_rtd_theme' | ||
|
|
||
| html_theme = "sphinx_rtd_theme" |
Check notice
Code scanning / CodeQL
Unused global variable
There was a problem hiding this comment.
Since Sphinx seems to use magic variables, I am unsure what pattern to use to suppress this warning. Might be worthwhile just manually dismissing this whenever we make an edit to this file. That way we'd still get CodeQL analysis everywhere else (where we are unlikely to use such weird patterns).
bbannier
force-pushed
the
topic/bbannier/pre-commit
branch
from
a585d7f
to
6aab9b6
Compare
ckreibich
requested changes
Jan 9, 2023
bbannier
force-pushed
the
topic/bbannier/pre-commit
branch
from
6aab9b6
to
e2e83e0
Compare
awelzel
reviewed
Jan 10, 2023
awelzel
reviewed
Jan 10, 2023
awelzel
reviewed
Jan 10, 2023
bbannier
force-pushed
the
topic/bbannier/pre-commit
branch
from
e2e83e0
to
2b0f8e7
Compare
Even though I am unsure this can actually lead to issues, this was flagged by CodeQL. Implementing a proper workaround instead of continously whitelisting these instances.
bbannier
force-pushed
the
topic/bbannier/pre-commit
branch
from
2b0f8e7
to
4a28a69
Compare
awelzel
reviewed
Jan 10, 2023
awelzel
approved these changes
Jan 10, 2023
ckreibich
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.