Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jruby spec runs #834

Merged
merged 1 commit into from Mar 15, 2024

Conversation

zmariscal
Copy link
Contributor

Purpose

With the new release of this gem we updated the version of jruby 0b22f67.

Fix

We were currently matching on jruby, but let's make sure we never run against jruby if the matrix ruby contains jruby.

@jkowens jkowens merged commit 5ea3ef0 into zdennis:master Mar 15, 2024
18 checks passed
@jkowens
Copy link
Collaborator

jkowens commented Mar 15, 2024

Awesome, thank you! For some reason jruby stable failed when running the mysql tests. I pinned it to jruby-9.4.5.0 but that should probably be addressed at some point.

@zmariscal zmariscal deleted the fix--allow-jruby-specs-to-pass branch March 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants