Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI against Ruby 3.3 #831

Merged
merged 1 commit into from Mar 19, 2024
Merged

CI against Ruby 3.3 #831

merged 1 commit into from Mar 19, 2024

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Mar 1, 2024 •
edited

This PR adds Ruby 3.3 to the CI matrix to ensure activerecord-import work with Ruby 3.3

@y-yagi y-yagi marked this pull request as ready for review March 1, 2024 04:06
@y-yagi
Copy link
Contributor Author

y-yagi commented Mar 1, 2024

It looks like JRuby 9.4.6.0 + activerecord-jdbcmysql-adapter raises an error. I'm doubting this is the same issue with jruby/jruby#8116.

@jkowens jkowens closed this Mar 19, 2024
@jkowens jkowens reopened this Mar 19, 2024
@jkowens
Copy link
Collaborator

jkowens commented Mar 19, 2024

Thank you!

@jkowens jkowens merged commit e4e06bf into zdennis:master Mar 19, 2024
41 of 42 checks passed
@y-yagi y-yagi deleted the ci-against-ruby33 branch March 19, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y-yagi @jkowens