Use ActiveRecord::Base.locking_enabled? to update the lock field #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thanks! |
|
Released in v1.6.0 👍 |
dombesz
added a commit
to opf/openproject
that referenced
this pull request
Mar 20, 2024
…n because the activerecord-import gem respects it. The zdennis/activerecord-import#822 got merged and released in the activerecord-import 1.6.0 which now respects the ActiveRecord::Base.lock_optimistically setting.
dombesz
added a commit
to opf/openproject
that referenced
this pull request
Mar 20, 2024
…n because the activerecord-import gem respects it. The zdennis/activerecord-import#822 got merged and released in the activerecord-import 1.6.0 which now respects the ActiveRecord::Base.lock_optimistically setting.
oliverguenther
pushed a commit
to opf/openproject
that referenced
this pull request
Mar 21, 2024
…n because the activerecord-import gem respects it. The zdennis/activerecord-import#822 got merged and released in the activerecord-import 1.6.0 which now respects the ActiveRecord::Base.lock_optimistically setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
activerecord-importis ignoring theActiveRecord::Base.lock_optimistically = falseflag and it still updates the lock field.Solution
Use the
locking_enabled?method provided by activerecord to decide whether the lock field should be updated.