Feature: Add Dockerfile and compose file #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have things work out of the box we need this small tweak so the host points to a future docker compose file change where the host will be called 'mysql'
zmariscal
commented
Sep 3, 2023
| - .:/usr/src/app | ||
| depends_on: | ||
| - mysql | ||
| command: tail -f /dev/null |
There was a problem hiding this comment.
There may be a better command to use here. It's just the simplest thing I could think of to ensure the container doesn't exit.
zmariscal
commented
Sep 3, 2023
|
|
||
| # Install system packages | ||
| RUN apt-get update -qq && \ | ||
| apt-get install -y default-mysql-client vim && \ |
There was a problem hiding this comment.
Adding vim isn't necessary, but it sure makes things easier to debug in container
|
Thanks @zmariscal this is a great idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make it easier for people to develop using Docker.
Implementation
Add a Dockerfile and docker-compose.yml to help developers be able to pull an image and run the application locally. You can read the README for how to do this. I went for the most minimal change to get mysql working first.
Potential future work
The next step would be to add
postgresqlas a service so someone can run the tests against that database service.