function/stdlib: Setproduct mark handling #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased + confirmed tests ✅ |
apparentlymart
force-pushed
the
setproduct
branch
from
665eeab
to
0f69a64
Compare
Setproduct will now preserve marks on both the arguments and their elements. Marks that apply to any entire argument will propagate to all return values, while marks applied to a single element will remain attached to individual values. In the cases where this function returns a set result the marks still end up aggregated at the root set value anyway due to cty's treatment of marks in sets, but we can retain the precision in the cases where we'll return a list.
apparentlymart
force-pushed
the
setproduct
branch
from
0f69a64
to
c968346
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setproduct will now preserve marks on both the arguments and their elements. Marks that apply to any entire argument will propegate to all return values, while marks applied to a single element will remain attached to individual values.