function/stdlib/keys: accept marked arguments #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
force-pushed
the
mildwonkey/sensitive
branch
4 times, most recently
from
5a45c63
to
62cea37
Compare
alisdair
reviewed
Apr 20, 2021
mildwonkey
force-pushed
the
mildwonkey/sensitive
branch
from
62cea37
to
0a5297a
Compare
|
tests are passing at the moment but seriously do not take my word for it; I seem to be having A Morning |
Since map keys can never be marked themselves, and this function doesn't return any of the values, we can safely ignore any markings on element values and just translate the shallow map marks to the result list as a whole.
apparentlymart
force-pushed
the
mildwonkey/sensitive
branch
from
0a5297a
to
518ba53
Compare
|
Thanks @mildwonkey! I concur with @alisdair's comment about the The rest of this looks just as I'd expect though, so I've just rebased this onto latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
Add AllowMarked: true
Re-apply top-level marks to result
If the entire map is marked, those marks are applied to the resulting list of keys. Inner marks are not preserved (only values can have marks).