Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional attributes from null values in all collections #141

Conversation

liamcervante
Copy link
Contributor

I've added test cases covering maps, lists, sets, and tuples and added checks for null values in the relevant conversion functions. I also added a general check that the conversion package won't skip removing optionals when the types match.

@apparentlymart apparentlymart merged commit f331651 into zclconf:main Oct 19, 2022
@liamcervante liamcervante deleted the liamcervante/optional-attributes-in-null-values branch October 20, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants