Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check each element for dynamic types in flatten #107

Merged
merged 1 commit into from May 14, 2021
Merged

Check each element for dynamic types in flatten #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions cty/function/stdlib/collection.go
View file
Open in desktop
Expand Up @@ -530,16 +530,18 @@ func flattener(flattenList cty.Value) ([]cty.Value, []cty.ValueMarks, bool) {
// predict the length of our result yet either.
return nil, markses, false
}
// Any dynamic types could result in more collection that need to be
// flattened, so the type cannot be known.
if flattenList.Type().HasDynamicTypes() {
return nil, markses, false
}

out := make([]cty.Value, 0)
isKnown := true
for it := flattenList.ElementIterator(); it.Next(); {
_, val := it.Element()

// Any dynamic types could result in more collections that need to be
// flattened, so the type cannot be known.
if val.Type().Equals(cty.DynamicPseudoType) {
isKnown = false
}

if val.Type().IsListType() || val.Type().IsSetType() || val.Type().IsTupleType() {
if !val.IsKnown() {
isKnown = false
Expand Down
52 changes: 51 additions & 1 deletion cty/function/stdlib/collection_test.go
View file
Open in desktop
Expand Up @@ -1953,7 +1953,57 @@ func TestFlatten(t *testing.T) {
}).Mark("marked"),
}),
}),
cty.DynamicVal,
cty.DynamicVal.Mark("marked"),
"",
},
{
cty.TupleVal([]cty.Value{
cty.ListVal([]cty.Value{
cty.ObjectVal(map[string]cty.Value{
"blop": cty.ListVal([]cty.Value{
cty.DynamicVal,
}),
}),
}),
cty.ListVal([]cty.Value{
cty.ObjectVal(map[string]cty.Value{
"bloop": cty.DynamicVal,
}),
}),
}),
cty.TupleVal([]cty.Value{
cty.ObjectVal(map[string]cty.Value{
"blop": cty.ListVal([]cty.Value{
cty.DynamicVal,
}),
}),
cty.ObjectVal(map[string]cty.Value{
"bloop": cty.DynamicVal,
}),
}),
"",
},
{
cty.ListVal([]cty.Value{
cty.ListVal([]cty.Value{
cty.ObjectVal(map[string]cty.Value{
"bloop": cty.DynamicVal,
}),
}),
cty.ListVal([]cty.Value{
cty.ObjectVal(map[string]cty.Value{
"bloop": cty.DynamicVal,
}),
}),
}),
cty.TupleVal([]cty.Value{
cty.ObjectVal(map[string]cty.Value{
"bloop": cty.DynamicVal,
}),
cty.ObjectVal(map[string]cty.Value{
"bloop": cty.DynamicVal,
}),
}),
"",
},
{
Expand Down