ElementFunc, ReverseListFun and SliceFunc mark handling #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElementFunc is updated to handle marks. If the requested element is marked, the return value will have the same mark. Likewise if the entire input list is marked, those marks will propegate to the return value.
Add precise mark handling to ReverseList func, plus some basic tests.
SliceFunc will now preserve marks on the input list as a whole, and any individual elements.
apparentlymart
approved these changes
Apr 30, 2021
Comment on lines
-192
to
+194
| l := args[0].LengthInt() | ||
| l := input.LengthInt() |
There was a problem hiding this comment.
It's funny that in this particular function we end up needing to unmark only because of this LengthInt call, because otherwise everything we do with args[0] is an operation method that will handle marks automatically! Having the length is important for this function though (to implement the wrapping behavior), so this does seem reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElementFunc, ReverseListFun and SliceFunc have been updated to handle marks, with tests!