CI: Alter ci-skip.yml to run in the context of the base of the PR
#6889
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
commented
May 9, 2024
| # variable. | ||
| # - never running commands with the fork's code checked out (we only require | ||
| # its commits to be present in the repository). | ||
| pull_request_target: |
There was a problem hiding this comment.
This workflow won't run for this PR because of this change:
- The workflow in this branch uses
pull_request_target, so won't run in the context of the PR. - The workflow currently in
masterusespull_request, so won't run in the context of the base branch.
Once we've admin-merged this PR, subsequent PRs should trigger fine, but it will continue to be the case that changes to ci-skip.yml won't actually start being used until after the PR they are in has merged.
This enables the workflow to set the "CI / Required status checks" status to "success" if the PR does not require CI.
str4d
force-pushed
the
ci-skip-fork-permissions
branch
from
29fa434
to
0e769ec
Compare
str4d
commented
May 9, 2024
| @@ -74,7 +85,11 @@ jobs: | |||
|
|
|||
| print('result=verified' if verified else 'result=skipped') | |||
| EOF | |||
| CHANGED_FILES=$(git diff --name-only ${{ github.base_ref }}...${{ github.event.pull_request.head.sha }} --) python3 ./subclass.py >> $GITHUB_OUTPUT | |||
| CHANGED_FILES=$(git diff --name-only ${{ github.sha }}...$HEAD_SHA --) | |||
| echo $CHANGED_FILES | |||
There was a problem hiding this comment.
I added this for debugging purposes; I plan to remove it once we know this workflow is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the workflow to set the "CI / Required status checks" status to "success" if the PR does not require CI.