Update CI with Github actions artifacts #6877
Conversation
y4ssi
changed the title
y4ssi
changed the title
| ${{ format('./src/test/test_bitcoin{0}', matrix.file_ext) }} | ||
| ${{ format('./src/zcash-gtest{0}', matrix.file_ext) }} |
There was a problem hiding this comment.
In the original GitHub Actions artifacts approach (that was replaced by GCA in be26acd), these particular binaries were stored in individual artifacts (with the rationale that we only needed one specific binary in the corresponding test jobs, so this would speed up the individual runners). Similarly, the other binaries were grouped based on what combinations were needed for testing. Does it work out to be simpler or faster to store all the binaries in one artifact?
There was a problem hiding this comment.
Yes, exactly, in the previous approach, we were optimizing. @daira had suggested combining them, which simplifies the code quite a bit. I'm satisfied with the time we've achieved, and I like the simplification. What I propose is to keep it for the sake of code simplicity/maintainability, and if in the future we see that the prices/time increase significantly or we're not satisfied, we can revisit it.
No description provided.